scide: sc_editor: include parenthesis in regionAroundCursor() #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When evaluating a region, the evaluated code excludes the parenthesis which define the region. If they are included instead, we avoid a parse error when evaluating array shortcut notations like `(1..3)`. Signed-off-by: Yvan Volochine <yvan.volochine@gmail.com>
|
Reported there: Note that I'm not sure that it's the best fix as it would allow the following syntax to be correct: But in the current state, the following is also correct so I guess this change would not harm: |
|
afaict, both code examples are valid sclang code. your patch looks good to me, though we don't need specific handling for Events in |
timblechmann
added a commit
that referenced
this pull request
Jun 30, 2013
scide: sc_editor: include parenthesis in regionAroundCursor()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When evaluating a region, the evaluated code excludes the parenthesis
which define the region. If they are included instead, we avoid a
parse error when evaluating array shortcut notations like
(1..3).