Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/ide cmdline #711

Merged
merged 2 commits into from
Jan 26, 2013
Merged

Conversation

timblechmann
Copy link
Contributor

this patch adds a shortcut (shift-ctrl-e) to fill the cmdline widget from a selection. does this sound reasonable?

using Ctrl+Shift+E, one can now fill a command line from the current
selection.

Signed-off-by: Tim Blechmann <tim@klingt.org>
Signed-off-by: Tim Blechmann <tim@klingt.org>
@telephon
Copy link
Member

Why is this necessary? Sorry for my ignorance, but isn't it possible to just evaluate the selection directly?

On 14.01.2013, at 10:43, Tim Blechmann notifications@github.com wrote:

this patch adds a shortcut (shift-ctrl-e) to fill the cmdline widget from a selection. does this sound reasonable?

You can merge this Pull Request by running

git pull https://github.com/timblechmann/supercollider topic/ide_cmdline
Or view, comment on, or merge it at:

#711

Commit Summary

• scide: fill command line from shortcut
• scide: avoid some duplicate code
File Changes

• M editors/sc-ide/core/main.cpp (5)
• M editors/sc-ide/core/main.hpp (1)
• M editors/sc-ide/widgets/cmd_line.cpp (10)
• M editors/sc-ide/widgets/cmd_line.hpp (2)
• M editors/sc-ide/widgets/code_editor/sc_editor.cpp (5)
• M editors/sc-ide/widgets/code_editor/sc_editor.hpp (1)
• M editors/sc-ide/widgets/help_browser.cpp (5)
• M editors/sc-ide/widgets/help_browser.hpp (1)
• M editors/sc-ide/widgets/main_window.cpp (45)
• M editors/sc-ide/widgets/main_window.hpp (3)
• M editors/sc-ide/widgets/post_window.cpp (5)
• M editors/sc-ide/widgets/post_window.hpp (1)
Patch Links:

https://github.com/supercollider/supercollider/pull/711.patch
https://github.com/supercollider/supercollider/pull/711.diff

@timblechmann
Copy link
Contributor Author

sure, you can evaluate the selection. however sometimes you have a line of code in a piece, but want to take this selecting and evaluate it with some modifications before you end up using this line in the piece. has the advantage of seeing both old and new code on the same screen. or you store an object into an environment variable and want to quickly evaluate some of its methods without writing into the document. at least, these are my use cases.

@telephon
Copy link
Member

On 15.01.2013, at 21:55, Tim Blechmann notifications@github.com wrote:

sure, you can evaluate the selection. however sometimes you have a line of code in a piece, but want to take this selecting and evaluate it with some modifications before you end up using this line in the piece. has the advantage of seeing both old and new code on the same screen. or you store an object into an environment variable and want to quickly evaluate some of its methods without writing into the document. at least, these are my use cases.

Ok, I see. Wouldn't it be a good idea to have a default notepad file open in which you can paste such lines and which behaves like any other document? It could be the default document and could come to focus with the shortcuts used for the cmdline widget, even adding to the end of it with one keystroke. This might be more generally useful.

@jleben
Copy link
Member

jleben commented Jan 21, 2013

On Mon, Jan 21, 2013 at 3:09 PM, Julian Rohrhuber
notifications@github.comwrote:

It could be the default document and could come to focus with the
shortcuts used for the cmdline widget, even adding to the end of it with
one keystroke. This might be more generally useful.

Sounds good to me! Something like a special "paste-to-scratch-buffer", or
even "copy-to-scratch-buffer" so one doesn't need to copy+paste.

@telephon
Copy link
Member

On 21.01.2013, at 20:29, Jakob Leben notifications@github.com wrote:

On Mon, Jan 21, 2013 at 3:09 PM, Julian Rohrhuber
notifications@github.comwrote:

It could be the default document and could come to focus with the
shortcuts used for the cmdline widget, even adding to the end of it with
one keystroke. This might be more generally useful.

Sounds good to me! Something like a special "paste-to-scratch-buffer", or
even "copy-to-scratch-buffer" so one doesn't need to copy+paste.

This would finally replace the decade-long practice of the "Untitled Document"! There could be one for each session, which is automatically saved and loaded.

@timblechmann timblechmann merged commit d12b5f4 into supercollider:master Jan 26, 2013
@timblechmann timblechmann deleted the topic/ide_cmdline branch July 26, 2015 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants