Poll: fix initialization to fire on first-sample trigger #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This seems to work as expected: (
{
var trig = Impulse.kr(1);
Sweep.kr(1).poll(trig);
FreeSelf.kr(PulseCount.kr(trig) >= 3);
Silent.ar(1)
}.play;
)results in While this looks fine to me, it does not produce the double posting at the beginning of the synth that you showed here. I just wanted to double check whether the behavior in this PR is exactly what you'd expect. |
Yes, that's the correct behavior. The double posting from before was just the quick "patch" for the previous thread, to make sure the issue wasn't with Impulse. Thanks for your attention to detail :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Pollmisses a trigger on the first sample... but not anymore!This bug was revealed only with the updated behavior of
Impulse(as of 3.13). There was no issue filed, but addresses a discussion that uncovered the bug.Types of changes
To-do list