Free/PauseSelf: restate state of Ctor after init sample calc #5914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telephon
reviewed
Nov 21, 2022
|
It likely will be necessary, I was just fixing the problem with |
telephon
approved these changes
Nov 21, 2022
|
@mtmccrea could you please rebase this on the |
mtmccrea
force-pushed
the
topic/fix-pauseself-ctor
branch
from
7aa4f21 to
190ae24
Compare
|
Thanks @dyfer does this look ok? |
|
Hm, the version change commit shouldn't be there. Maybe I messed up something with the branches...? |
|
I had exactly the same when rebasing. I hand reverted that commit. So yes, maybe there is something wrong in |
|
@mtmccrea can you do interactive rebase and remove the version change commit? Sorry the branch state is messy |
mtmccrea
force-pushed
the
topic/fix-pauseself-ctor
branch
from
190ae24 to
1802580
Compare
telephon
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset state of
PauseSelfandFreeSelfafter init sample calculation, otherwise a trigger on the first sample will be missed.Note the
FreeSelfchange fixes an edge case where a UGen would free the synth on the first sample.This example doesn't currently work, but works with this proposed fix.
( x = { Silent.ar.poll(4, label: "I am not paused."); // FreeSelf.kr(Impulse.kr(0)); // immediately free FreeSelf.kr(Impulse.kr(1, phase: 0.5)); // free after 0.5 sec }.play )Purpose and Motivation
Fixes #5910, and hopefully SuperDirt #277
Types of changes
To-do list