-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quark hooks continued #5907
Quark hooks continued #5907
Conversation
Thanks @telephon, this looks good and I'd like to include it in the next RC. Could you please rebase it on the |
f28037b
to
8d913cd
Compare
I forgot how to do this. Do you have a hint? |
|
@telephon would you be able to rebase this branch to remove the superfluous commits? |
8d913cd
to
88ddbd0
Compare
I hope this is how it should look like? I am not sure what the final state of this PR should be. |
@telephon thanks for making changes! It's close, but not quite there yet. |
Instead of writing files, set values in a class variable.
88ddbd0
to
c8a933c
Compare
ah yes, so this should be better. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Purpose and Motivation
This is a continuation of #5780.
See discussion there.