HistoryGui: improve display readability (fontsize and tabWidth) #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telephon
reviewed
Sep 1, 2022
| @@ -66,6 +68,8 @@ HistoryGui : JITGui { | |||
| }; | |||
| }; | |||
| }) | |||
| .font_(font) | |||
| .tabWidth_(font.size * 0.6 * 4) // ca. 4 chars | |||
There was a problem hiding this comment.
Maybe better:
"1234".bounds(font).width?
There was a problem hiding this comment.
tabWidth_ seems to be a pixel size, according to documentation
There was a problem hiding this comment.
yes, that is better, done.
telephon
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
HistoryGui has not been updated for Qt Guis, and thus had visual problems:
Too small font size and too large tabWidth.
Also, the window name was a bit confusingly "HistoryGui_History",
which this PR clarifies to just say "History".