-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppClock schedAbs #5851
AppClock schedAbs #5851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the LinkClock issue, would you mind adding documentation for schedAbs? New methods should be documented unless they are private.
… and improve sched example
I just had a quick coffee. :) |
Ha ha! OK... what happened was, I was just sitting down to add schedAbs myself, and then saw an e-mail that you had done it, and went to review it quickly. I think that a prior SC maintainer would have preferred CondVar over So perhaps:
|
Yes, I did see your suggestion further up. I had decided for simplicity – while I do understand conditions, I have to admit that I have to read three times the code needed to use them … |
OK, so here is a test series that factors out the "complicated" bits. |
@jamshark70 if you have the time, could you review it and if ok mark your change request as fulfilled? |
testsuite/classlibrary/TestTask.sc
Outdated
} | ||
|
||
test_play_with_TempoClock { | ||
this.makePlayTestWithClock(TempoClock.default, "TempoClock.default"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd have to suggest TempoClock.new
here, because it will be stop
-ped later. (As a rule of thumb, if this block of code didn't create the clock, then it shouldn't be stopping the clock.)
@jamshark70 do you have any more requests for this PR? |
LGTM 👍 |
Purpose and Motivation
Fixes #5700.
Types of changes
To-do list