test: correct wrong assumption in test #5801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One would naturally assume that ControlNames always contain numbers as defaultValues, but here we use them differently: any object can be value of the ControlNames. This is now tested and documented.
dyfer
added
comp: help
|
Thanks! Could you also remove skipping for the now non-existing test from here? |
|
I'm going to push a suggested change to this PR, I hope that's okay. |
|
CI failures are unrelated to this PR (see the previous run for reference). I'm going to merge this. |
dyfer
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
One would naturally assume that ControlNames always contain numbers as defaultValues, but here we use them differently: any object can be value of the ControlNames. This is now tested and documented.
See also #5796 and #5797.
Types of changes
To-do list