Update Linux build matrix #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyfer
added
os: Linux
comp: CI/CD
dyfer
force-pushed
the
topic/update-linux-build-matrix
branch
from
142da6f to
50abc11
Compare
dyfer
force-pushed
the
topic/update-linux-build-matrix
branch
from
08e73ff to
c3fd7ad
Compare
dyfer
force-pushed
the
topic/update-linux-build-matrix
branch
3 times, most recently
from
ab9d44b to
633e098
Compare
dyfer
force-pushed
the
topic/update-linux-build-matrix
branch
2 times, most recently
from
2fbb04f to
2a84182
Compare
|
I've rebased the PR to resolve the merge conflict in the README.md. |
some builds are on ubuntu 22.04
dyfer
force-pushed
the
topic/update-linux-build-matrix
branch
2 times, most recently
from
824d63d to
0a94d6f
Compare
dyfer
force-pushed
the
topic/update-linux-build-matrix
branch
from
0a94d6f to
b1f062e
Compare
joshpar
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Our build matrix had no builds on Ubuntu 22.04 and only one on 20.04. This update brings building using newer compilers and newer OSs.
Please note, Linux builds withclang-11,clang-12andclang-13fail to build (see https://github.com/dyfer/supercollider/runs/6531974521?check_suite_focus=true) and are thus disabled. I don't know whether the issue has to do with the OS configuration/missing packages, or with our build system... However, clang builds seem to be fine on macOS (I think locally I've been building using all or most of these clang versions throughout the last few years) so I'm hoping this is not an issue with our codebase.EDIT: After discussion with @jrsurge he decided to look into the reason for these failures. Let's wait for a proposed fix before merging this PR.EDIT: it turns out that issue with clang builds was due to missing libraries; we needed to install proper versions of the
libc++libs in CI and this PR now provides that.I've also updated the Qt5 package name for Ubuntu, which seems to work fine in all the OS versions we use here (18.04, 20.04, and 22.04).
EDIT:
I also updated the tests to run on Ubuntu 20.04. This was semi-intended change, but I think it's better to test on a slightly newer system anyway...That seemed to be failing for some reason when installing QPM. Fixing that is definitely out of scope for this PR, so I reverted to testing with 18.04.I updated
"tested with" and"known to support" entries in ourREADME.md. The "guaranteed support" section should be updated too, but I think it's out of scope for this PR.Types of changes
To-do list