Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
A new version of libsndfile (1.1.0) was released and I wanted to update our macOS and Windows builds.
This is a little more invasive than I'd like. I switched both macOS and Windows builds to use vcpkg to supply libsndfile.
verify_app
; i.e. libsndfile as shared library is fine, but its dependencies (libvorbis, flac etc) were confusing to CMake's verify mechanism (though seemed to work fine). In any case, I decided to create a custom vcpkg triplet, which builds only selected libraries as shared, and the rest as static. This creates a single libsndfile library with all dependencies built-in and passesverify_app
libsndfile
from vcpkgI tested the legacy build on macOS 10.11 and it still seems to work, the server boots (I had to revert an XCode version change I originally introduced in this for it to keep working).
A basic test for this PR would be to download the build and make sure it starts and that the server boots, maybe read a soundfile too.
Types of changes
To-do list