Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW Vim like keyshortcuts in HelpBrowser #5742

Merged
merged 2 commits into from
Nov 7, 2022
Merged

NEW Vim like keyshortcuts in HelpBrowser #5742

merged 2 commits into from
Nov 7, 2022

Conversation

paum3
Copy link
Contributor

@paum3 paum3 commented Mar 9, 2022

Purpose and Motivation

Users of fantastic scnvim plugin in neovim can choose pandoc version of helpfiles, or classic style, which uses HelpBrowser class. For those, which are using a classic helpdoc this PR adds some VIM like keystrokes for comfortable browsing documentation. I've found it very useful and handy, code is tested & working on Linux.

the new keys are:

  • h,j,k,l - back histo,down, up, forward histo
  • ctrl + D, ctrl + U - bigger step scroll down, up
  • g,G - go to top, to bottom of document
  • J,K - zoom out, zoom in
  • F3 - go to main Search page
  • F5 - reload page
  • / - search page
  • alt + leftArrow, alt + rightArrow - back histo, forward histo

Types of changes

  • New feature

To-do list

This needs to be checked on other than Linux platforms.

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

joshpar
joshpar requested changes Jul 15, 2022
View reviewed changes
Copy link
Member

@joshpar joshpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! A couple of suggestions that I'd like to see, but if someone else approves without the change I won't be heartbroken

SCClassLibrary/Common/GUI/tools/HelpBrowser.sc Show resolved Hide resolved
SCClassLibrary/Common/GUI/tools/HelpBrowser.sc Show resolved Hide resolved
@paum3 paum3 requested a review from joshpar August 22, 2022 14:47
@joshpar joshpar merged commit e8692e3 into supercollider:develop Nov 7, 2022
@paum3 paum3 deleted the topic/qwebview_vim_keys branch November 8, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpar joshpar joshpar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paum3 @joshpar