Add tag name in the about dialog for tagged builds #5697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Before this PR, the "About" dialog in the IDE of the release (tagged) builds would report
Built from branch 'HEAD' [<SHA>]
. After this PR, the dialog readsBuilt from tag '<tag-name>' [<SHA>]
. The non-tagged builds display the branch name as they have previously.Here are the dialogs from builds from this branch and from a temporary tag:
For a tagged commit, the beginning of cmake config now looks like this:
API change...?
There is a very slight change to the response in the server API, if we even consider this a change. Previously, for the release builds the response to the
/version
message would includeHEAD
as the branch name, while currently it returns the tag name. These fields are marked in the help as informational only, so I don't believe it's an actual issue, but I wanted to point it out for the completeness sakeResponse:
Types of changes
To-do list