-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UnitTest test_seti_nodeMap again #5687
Conversation
The test passes locally but failes on GHA. Therefore it's been added to gha_test_run_proto.json Signed-off-by: Stefan Nussbaumer <st9fan@gmail.com>
@@ -153,6 +153,12 @@ | |||
"test":"test_findText_notFound", | |||
"skip":true, | |||
"skipReason":"UnitTest sometimes fails when run in qpm" | |||
} | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the formatting correct? Your code seems to be inlined differently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... I've seen that too in the diff. However, formatting looks correct in my forked repo: https://github.com/nuss/supercollider/blob/NodeProxy-seti/testsuite/scripts/gha_test_run_proto.json
I've tried to keep my entry in line with other entries (indenting with spaces, not tabs). So, if formatting's not right I don't really know what's wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... sorry, I thought I had formatted my entry with spaces (in vim) but there were some tabs left.
I thought I had formatted my entry with spaces but obviously there were tabs in it. Signed-off-by: Stefan Nussbaumer <st9fan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
|
The test passes locally but failes on GHA. Therefore it's been added to
gha_test_run_proto.json
Signed-off-by: Stefan Nussbaumer st9fan@gmail.com
Purpose and Motivation
The test
test_seti_nodeMap
has always passed on my local machine but fails in GHA. So I've added the test togha_test_run_proto.json
Types of changes
To-do list