Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnitTest test_seti_nodeMap again #5687

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Conversation

nuss
Copy link
Contributor

@nuss nuss commented Jan 9, 2022

The test passes locally but failes on GHA. Therefore it's been added to
gha_test_run_proto.json

Signed-off-by: Stefan Nussbaumer st9fan@gmail.com

Purpose and Motivation

The test test_seti_nodeMap has always passed on my local machine but fails in GHA. So I've added the test to gha_test_run_proto.json

Types of changes

  • Bug fix

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

The test passes locally but failes on GHA. Therefore it's been added to
gha_test_run_proto.json

Signed-off-by: Stefan Nussbaumer <st9fan@gmail.com>
@nuss nuss mentioned this pull request Jan 9, 2022
4 tasks
@@ -153,6 +153,12 @@
"test":"test_findText_notFound",
"skip":true,
"skipReason":"UnitTest sometimes fails when run in qpm"
}
},
{
Copy link
Member

@telephon telephon Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the formatting correct? Your code seems to be inlined differently.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good catch @telephon , the new addition has tabs while the rest of the file uses spaces. @nuss could you change the new code to spaces please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... I've seen that too in the diff. However, formatting looks correct in my forked repo: https://github.com/nuss/supercollider/blob/NodeProxy-seti/testsuite/scripts/gha_test_run_proto.json
I've tried to keep my entry in line with other entries (indenting with spaces, not tabs). So, if formatting's not right I don't really know what's wrong.

Copy link
Contributor Author

@nuss nuss Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... sorry, I thought I had formatted my entry with spaces (in vim) but there were some tabs left.

I thought I had formatted my entry with spaces but obviously there were
tabs in it.

Signed-off-by: Stefan Nussbaumer <st9fan@gmail.com>
Copy link
Member

@dyfer dyfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dyfer dyfer merged commit 7998e2c into supercollider:develop Jan 10, 2022
@dyfer
Copy link
Member

dyfer commented Jan 19, 2022

test_seti_nodeMap got enabled in #5702, along with a fix (using a separate server object; otherwise the default server would run out of bus allocation pool)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants