Topic fix some tests #5676
Topic fix some tests #5676
Conversation
When a node map is copied, the values of the `out` control must differ. So better not test for this ...
The time wasn't enough for the server to have fully released the synthDef.
|
Thanks so much for this, @telephon ! Could you also remove the fixed tests from the exclusion list in https://github.com/telephon/supercollider/blob/topic-fix--some-tests/testsuite/scripts/gha_test_run_proto.json ? That way they'll be run in the CI again. |
| @@ -267,7 +267,7 @@ TestNodeProxy : UnitTest { | |||
| timeout.stop; | |||
| resp.free; | |||
|
|
|||
| this.assertEquals(result, proxy.source, "after the crossfade from a ugen function to a value the bus should have this value"); | |||
| this.assertFloatEquals(result, proxy.source, "after the crossfade from a ugen function to a value the bus should have this value"); | |||
There was a problem hiding this comment.
Did test_control_fade fail before? If not, what's the rationale for this change?
| @@ -71,6 +71,7 @@ TestNodeProxy_Server : UnitTest { | |||
| // ... and also afterwards, we force an update | |||
| server.sendStatusMsg; | |||
| server.sync; | |||
| 0.8.wait; | |||
There was a problem hiding this comment.
Is this really the only way to fix this? This is a rather lengthy wait. Could this be addressed by sending some other message to the server and running another server.sync? Or maybe trying the shorter wait time?
If you remove the exclusion from gha_test_run_proto.json we'll be able to see how the shorter wait time performs in the CI (which is arguably not tuned for audio/low-latency performance).
There was a problem hiding this comment.
I agree. I find it weird that this doesn't work faster, but it has to do with the time the server takes to report the deallocation of the synth def.
There was a problem hiding this comment.
I've found another solution: just fix the wrong order in the sync …
dyfer
added
the
comp: testing
|
Hey @adcxyz |
|
No worries @adcxyz |
|
|
Purpose and Motivation
NodeProxy tests that failed because of wrong assumptions in the test.
Types of changes
To-do list