Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for LIB_SUFFIX #5644

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Add option for LIB_SUFFIX #5644

merged 1 commit into from
Feb 7, 2022

Conversation

tdug
Copy link
Contributor

@tdug tdug commented Dec 15, 2021

Purpose and Motivation

This makes the option of LIB_SUFFIX visible with cmake -L

Types of changes

  • Documentation

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

@tdug
Copy link
Contributor Author

tdug commented Dec 15, 2021

Related: supercollider/sc3-plugins#328

@tdug tdug mentioned this pull request Dec 15, 2021
Merged
@dyfer
Copy link
Member

dyfer commented Jan 12, 2022

Thanks @tdug
Sorry I'm not aware - could you explain in what circumstances we need this option?

@tdug
Copy link
Contributor Author

tdug commented Feb 7, 2022

Thanks @tdug Sorry I'm not aware - could you explain in what circumstances we need this option?

@dyfer - This option already exists, and is documented here This pull request documents that option when running cmake -L.

@dyfer
Copy link
Member

dyfer commented Feb 7, 2022

Thanks for the explanation!

@dyfer dyfer merged commit 4cbdee5 into supercollider:develop Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyfer dyfer dyfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdug @dyfer