Revert #4725 - MIDI use logical time on macOS #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyfer
added
comp: sclang
jamshark70
previously requested changes
Dec 2, 2021
jamshark70
dismissed
their stale review
My question was answered in comment threads
joshpar
approved these changes
Dec 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c6790a9, reversing changes made to 13be6e8.
Purpose and Motivation
Fixes #5622
See linked issue for explanation and details.
I also cherry-picked CI commit that fixes the macOS legacy build.
I'm suggesting to merge this into
3.12branch in order to release3.12.2with this fix, but I'm open to suggestions about this.Types of changes
To-do list