Classlib: Allow any type of text stream in the FileReader hierarchy #5611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
But... FileReader's interaction with the
stream
is, in total:stream.reset
--CollStream
implements thisstream.getChar
--CollStream
implements thisstream.close
--CollStream
doesn't implement this, but we can usetryPerform
to make it a no-opSo there is not a compelling reason why a FileReader must be accessing a file on disk and disallow a stream of characters in memory.
(Editorial: The usual OOP advice is to program toward interfaces rather than class hierarchies:
respondsTo
rather thanisKindOf
. This looks like a case where "oh,isKindOf
will be fine just this once" except that it isn't, not really.)Since the really relevant operation is
getChar
, this PR changes the FileReader constructor so that any object implementinggetChar
will be allowed as the stream.Types of changes
To-do list