Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sc-el to latest version #5600

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Update sc-el to latest version #5600

merged 1 commit into from
Dec 4, 2021

Conversation

jxa
Copy link
Contributor

@jxa jxa commented Oct 19, 2021

Purpose and Motivation

Merges in latest commit from scel submodule. PR for those changes is supercollider/scel#39

Types of changes

  • Documentation
  • Additional deployment options

To-do list

  • This PR is ready for review

@dyfer
Copy link
Member

dyfer commented Oct 19, 2021

Thanks @jxa !
Some background information: I've reviewed supercollider/scel#39 and I think it's all good - scel can still be installed with CMake, like we did in the past. The updated version can be also installed as a quark and @jxa updated bunch of things in scel in the process.
I'll leave this PR up for a while to give others a chance to look at it and if there are no objections I'll merge it afterwards.

dyfer
dyfer approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@dyfer dyfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dyfer dyfer merged commit 92c6ded into supercollider:develop Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyfer dyfer dyfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxa @dyfer