-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
class library: refactor functionality: connectToServerAddr #5569
class library: refactor functionality: connectToServerAddr #5569
Conversation
Thanks so much!
|
I'm still usure whether In fact, I would have thought it good to pack the |
Yeah... the whole |
@adcxyz did a rather large rewrite long ago, but as far as I know, it somehow was never taken up and merged. |
Yes, that was discussed here : #3310 |
Ah good, thanks for pointing to this. As you wrote, the branches have diverged. What do you think: is the current PR doing harm (I am always ready to minimize impact at the cost of beauty :)) |
what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, clearer than before.
Purpose and Motivation
While looking for a fix of #5568, a small refactoring was recommended.
Types of changes
To-do list