Add kitty and alacritty to list of Linux terminals #5548
Conversation
|
should be good now @dyfer thanks |
|
I think the indentation is still off - in the class library we use tabs for indentation |
Sorry, had never noticed this but I think I found a way to change this setting in my editor. Hope it's better now :) |
|
Thanks for the changes! The tabs are good now. As for the functionality, I'll try to test in the next few days so that this can be merged. |
|
Sorry about the whitespace. Should be removed now.
…--
Best regards, Mads Kjeldgaard
On 22-08-2021, Marcin Pączkowski wrote:
Thanks for the changes! The tabs are good now.
Sorry to be a pain about this, but there are also spaces after the commas (before the newline), it would be great to remove those as well, I noticed them by looking at [this part of the diff](https://github.com/supercollider/supercollider/pull/5548/files#diff-2c0665171d7933ed14a0d8598c8ad3583d44599dde44592d92060e410cb807a9L51-R51)
As for the functionality, I'll try to test in the next few days so that this can be merged.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#5548 (comment)
|
|
Hi @dyfer has this been included in a release yet? |
|
Hi @madskjeldgaard, sorry, I don't think so. It was off my radar and I forgot to cherry-pick it. But we will likely be releasing 3.13 soon-ish, it will be included there. Is that okay? |
|
Yeah that's great. Thanks Marcin ! |
Purpose and Motivation
This adds to the awesome work made on the LinuxPlatform class in 3.12 where .runInTerminal was improved and had default terminals added to it. The list is missing two (gpu accelerated and) popular terminals: kitty and alacritty and so this is a simple PR that adds those two
Types of changes
To-do list