Build libsndfile's dependencies and change DMG filesystem #5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyfer
added
os: macOS
Work In Progress (WIP) - don't merge yet
comp: CI/CD
dyfer
force-pushed
the
macos-legacy-3.12
branch
from
f464251 to
31a68fd
Compare
joshpar
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Fixes #5536
There seem to be 2 issues with the current macOS legacy build:
libsndfileourselves, it depends onlibvorbisand other libraries provided by homebrew.I propose to change this by building all of the libsndfile's dependencies ourselves (libvorbis, libogg, flac, opus). I've also changed filesystem in the DMG to HFS+.
Currently in this PR all of the libsndfile's dependencies (libvorbis, libogg, flac, opus) are built as static libraries.
libsndfileitself stays as shared library. Please let me know what you think about this. I was having problems when they were all shared libraries.I'm still testing whether the build is taking advantage of ccache.ccache seems to be working. The build time for libsndfile et al went from 3+' to ~1'30".Since our 3.12.0 legacy builds don't seem to support some legacy systems, I'm suggesting to put this into 3.12 branch and release a patch release (3.12.1) with this fix later on.
Types of changes
To-do list