Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing block arguments bug #5522

Merged
merged 5 commits into from
Nov 7, 2022
Merged

Conversation

nilninull
Copy link
Contributor

Purpose and Motivation

The interpret, interpretPrint, and executeFile methods of the Interpreter class take arguments to the block of code, but cannot execute them.

This code is an example.

this.interpret("arg a, b; a + b", 3, 4)
this.interpret("| a, b | a + b", 3, 4)

I thought this was a parser bug, so I fixed it.

Note: bison used the latest version.

Types of changes

  • Bug fix

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

@dyfer dyfer added the comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library" label Jul 25, 2021
@joshpar joshpar self-assigned this Feb 20, 2022
@joshpar
Copy link
Member

joshpar commented Feb 20, 2022

Note to self: check the LPC regression tests before merging.

@dyfer
Copy link
Member

dyfer commented Nov 7, 2022

For reference: after discussion with @joshpar we decided to merge this.

Copy link
Member

@dyfer dyfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dyfer dyfer merged commit 02c37d2 into supercollider:develop Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants