Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerPlusGUI: defer GUI updates #5491

Merged
merged 1 commit into from
Jan 30, 2022
Merged

ServerPlusGUI: defer GUI updates #5491

merged 1 commit into from
Jan 30, 2022

Conversation

dyfer
Copy link
Member

@dyfer dyfer commented Jun 29, 2021 •
edited
Loading

Purpose and Motivation

Fixes #5485

Before this fix, the following would cause ERROR: Qt: You can not use this Qt functionality in the current thread. Try scheduling on AppClock instead. (...):

(
(Server.program + ServerOptions().maxLogins_(10).asOptionsString).unixCmd;
Server.default.makeGui;
)

// recompile class library

// after recompile run
Server.default.makeGui;

See the issue for more information.

Types of changes

  • Bug fix

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

@dyfer dyfer added the comp: class library SC class library label Jun 29, 2021
@dyfer
Copy link
Member Author

dyfer commented Jul 6, 2021

I've only deferred the methods that were throwing an error in my reproducer. Should I also defer other GUI methods attached to the SimpleController, e.g. https://github.com/supercollider/supercollider/pull/5491/files#diff-a35b5be480643c127f781e8f7c8cc60f263ca1af432aa3c881ba3d043623e6c0L336 ?

@dyfer dyfer merged commit 40417b0 into supercollider:develop Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpar joshpar joshpar approved these changes

Assignees
No one assigned
Labels
comp: class library SC class library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server GUI - some messages are not scheduled on AppClock
2 participants
@dyfer @joshpar