macos: clip output values on supernova #5454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyfer
force-pushed
the
topic/macos-clipping
branch
from
d198b59 to
f78552d
Compare
dyfer
force-pushed
the
topic/macos-clipping
branch
from
eaf2616 to
9705ce6
Compare
|
(still doesn't work, WIP) |
dyfer
force-pushed
the
topic/macos-clipping
branch
from
9705ce6 to
901fb28
Compare
|
I think this works now. I used I don't really know what I'm doing here - please review and test carefully! Here is my testing code: s.options.outDevice_("Built-in Output"); // optionally
(
Server.supernova;
s.options.safetyClipThreshold_(0.16); // clips
s.reboot;
s.doWhenBooted({
x = {SinOsc.ar(600, 0, 0.dbamp)}.play;
})
)
(
Server.scsynth;
s.options.safetyClipThreshold_(1.26); // default - clips (LOUD!)
s.reboot;
s.doWhenBooted({
x = {SinOsc.ar(600, 0, 6.dbamp)}.play;
})
)
(
Server.scsynth;
s.options.safetyClipThreshold_(nil); // also default - clips (LOUD!)
s.reboot;
s.doWhenBooted({
x = {SinOsc.ar(600, 0, 6.dbamp)}.play;
})
)
( // WARNING
Server.scsynth;
s.options.safetyClipThreshold_(0); // NO CLPPING (LOUD!)
s.reboot;
s.doWhenBooted({
x = {SinOsc.ar(600, 0, 6.dbamp)}.play;
})
) |
dyfer
force-pushed
the
topic/macos-clipping
branch
from
901fb28 to
28ff671
Compare
dyfer
commented
May 25, 2021
dyfer
commented
May 25, 2021
joshpar
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Clip loud signals on macOS on supernova. See scsynth version #5412 for the detailed description. Thanks @elgiano !
I've taken @elgiano 's WIP branch and
his implementation seems to work as expected for me so I'm submitting this PRmade some changes.Fixes #5412
Types of changes
To-do list