Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: add github actions for linux and macos #5273

Merged
merged 2 commits into from
Dec 2, 2020
Merged

GHA: add github actions for linux and macos #5273

merged 2 commits into from
Dec 2, 2020

Conversation

dyfer
Copy link
Member

@dyfer dyfer commented Dec 1, 2020 •
edited
Loading

Purpose and Motivation

Add GitHub Actions CI for linux and macOS. See #5261 for prior discussion

Implemented:

  • build matrix for both linux and macOS (mostly complete)
  • ccache (cached between builds)
  • linting
  • artifact names use either tag or commit sha (if tag is not present)

todo:

  • upload/publish nightly builds

not implemented / for later:

  • run tests
  • create windows builds
  • fix macOS legacy builds
  • automatic deployment

Notes:

  • I think we need a new label. Should it be "GitHub Actions", "GHA", "Actions" or maybe just "CI"?
  • Most names (like names of steps etc) are starting lowercase now. Is this OK or should they start with a capital letter?
  • For nightly builds: we either need to upload them to S3, or maybe there's a way to use some external script with GH API?
  • I've set artifacts to expire quickly (7 days); I think that's fine for PRs, but I thought that maybe artifacts on the main repo/branches should expire longer; this should be easy to implement I think

Types of changes

  • New feature

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

@dyfer dyfer requested a review from mossheim December 1, 2020 18:52
@dyfer
Copy link
Member Author

dyfer commented Dec 1, 2020

Hm... GHA doesn't seem to activate on a PR.
Also when I started on my repo, I had to additionally confirm making changes to Actions on the first push. Do we need to merge this first and open another PR for making changes to it?

@dyfer dyfer force-pushed the topic/github-actions branch from 1729ce4 to 4943be2 Compare December 1, 2020 19:28
@mossheim mossheim closed this Dec 2, 2020
@mossheim mossheim reopened this Dec 2, 2020
@mossheim mossheim added the comp: build CMake build system label Dec 2, 2020
@mossheim
Copy link
Contributor

mossheim commented Dec 2, 2020

i think we need to merge this first before GH will let us run actions, since it's not on a branch on this repo. just my guess, but it also seems like it would be a reasonable protection against people abusing unsuspecting projects for build time.

@mossheim
Copy link
Contributor

mossheim commented Dec 2, 2020

i'm going to just merge this now so we have something to work with, and i trust that if it works on your fork it should work here too. since you said you wanted to take a break anyway, rather than review this PR i'll just submit a new PR myself if there's anything i think we should add or change. thanks again for all your work on this

@mossheim mossheim merged commit f279c02 into supercollider:develop Dec 2, 2020
@dyfer dyfer added comp: CI/CD continuous integration and deployment (github actions, etc.) and removed comp: build CMake build system labels Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossheim mossheim mossheim approved these changes

Assignees
No one assigned
Labels
comp: CI/CD continuous integration and deployment (github actions, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyfer @mossheim