Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: with macOS+QtWebEngine+Qt5.15.1, mark all manually deployed files writeable #5230

Merged
merged 1 commit into from
Nov 1, 2020
Merged

cmake: with macOS+QtWebEngine+Qt5.15.1, mark all manually deployed files writeable #5230

merged 1 commit into from
Nov 1, 2020

Conversation

mossheim
Copy link
Contributor

@mossheim mossheim commented Nov 1, 2020

Purpose and Motivation

fixes #5222

Types of changes

  • Bug fix

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

elgiano
elgiano approved these changes Nov 1, 2020
View reviewed changes
Copy link
Contributor

@elgiano elgiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it looks good!

@mossheim mossheim added comp: build CMake build system os: macOS labels Nov 1, 2020
@mossheim mossheim merged commit af7841f into supercollider:3.11 Nov 1, 2020
@mossheim mossheim deleted the topic/issue-5222 branch November 1, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elgiano elgiano elgiano approved these changes

Assignees
No one assigned
Labels
comp: build CMake build system os: macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossheim @elgiano