add legacy build temporarily #5190
Conversation
|
thanks @dyfer ! i noticed two differences from the develop legacy build:
i'm not sure if it's intentional. i think we want the 3.11 branch legacy build to match the develop one as closely as possible. that way, we only need to worry about maintaining one legacy configuration. does that make sense? i guess it would be awkward to have the 'legacy' build made with an xcode version newer than the 'modern' build, but that's more a result of us not upgrading the 3.11 branch's existing builds. |
|
Yes, these differences are intentional. For xcode - exactly, I thought it would be weird to have legacy build done with a newer version. I don't feel strongly about either decision, let me know if you think I should not update homebrew and use newer xcode. I treat this as a "temporary" legacy build. |
|
yeah, i totally understand that. mainly i am thinking about stability -- if we have two different legacy build configurations, one for 3.11 and one for develop, then we will need to triage and fix issues that arise with both. if we only have one that is shared between branches, that leaves a smaller surface area for bugs to arise. it also means slightly more stability for macOS 10.12 users moving from 3.11.2 to 3.12.0. in some ways we can think of the 3.11.2 release as the 'test run' for the legacy artifact in 3.12.0. we did just see a major bug caused by a patch version bump (qt 5.15.0 to 5.15.1) that took several days to resolve. i know that this is a rarity, and i agree that it's probably safe either way, but i would just prefer we don't have to think about these possibilities at all. |
dyfer
force-pushed
the
topic/add-legacy-build-temporarily
branch
from
7903534 to
c911abf
Compare
|
I updated the PR as requested. Should I push a tag to test deployment again? |
|
thanks! yes, if you don't mind. |
dyfer
force-pushed
the
topic/add-legacy-build-temporarily
branch
from
c911abf to
c7f6c6e
Compare
|
There was one more change needed, because of updated fftw - path in fftw linking fix. I also pushed a tag: https://github.com/supercollider/supercollider/releases/tag/3.11-legacy-test-02 |
Purpose and Motivation
Add legacy build for the 3.11 branch, as discussed in #5188 (comment)
This PR focuses on a minimal amount of changes, copied from #5174
As the implementation is incomplete (e.g. macos deployment is active for all builds, instead of conditional on specified prefix/suffix), these changes should be discarded when merging 3.11 back to develop
The deployment itself was tested:
https://github.com/supercollider/supercollider/releases/tag/3.11-legacy-test-01
see also s3 legacy build and s3 regular build
Types of changes
To-do list