SynthDesc and SynthDescLib should restore metadata to their SynthDefs too #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamshark70
added
bug
mossheim
suggested changes
Aug 9, 2020
mossheim
suggested changes
Aug 13, 2020
| @@ -0,0 +1,57 @@ | |||
| TestSynthDescMetadata : UnitTest { | |||
| var dir, path, mdPath, metadata, original, oldMdPlugin; | |||
| var defname = \test_md; | |||
There was a problem hiding this comment.
i think you can make this a const? or are symbol literals not compatible with const...
| test_SynthDescLib_read_restores_metadata_in_desc_and_def { | ||
| var synthdesc; | ||
| synthdesc = SynthDescLib.read(dir +/+ "*.scsyndef").global; | ||
| synthdesc = synthdesc[\test_md]; |
There was a problem hiding this comment.
should be defname, same above (line 29)
jamshark70
force-pushed
the
topic/SynthDescMetadata
branch
from
125a5cf to
11d5681
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Fixes an issue noted on sc-users.
If a SynthDef has been written to disk with metadata, and later read from disk, in the current release you get:
SynthDescLib.global.at(defname).metadatacontains the metadata.SynthDescLib.global.at(defname).def.metadata-- the reconstructed SynthDef -- does not contain the metadata.Unit testing was (as is often the case) trickier than expected to write -- but the process of writing it identified a second code path reading the metadata, so the fix is more thorough than was discussed on the mailing list.
Types of changes
To-do list