Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix args explanation SelectXFocus.schelp #5078

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Fix args explanation SelectXFocus.schelp #5078

merged 1 commit into from
Jul 12, 2020

Conversation

brunoruviaro
Copy link
Contributor

'focus' arg was explained backwards.

Purpose and Motivation

'focus' arg was explained backwards -- with focus approaching 1, less (not more) adjacent channels are mixed in.

Types of changes

  • Documentation

To-do list

  • [x ] Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

@brunoruviaro
Fix args explanation SelectXFocus.schelp
40ad2b6 
'focus' arg was explained backwards.
@patrickdupuis
Copy link
Contributor

patrickdupuis commented Jul 8, 2020 •
edited
Loading

Thanks for this! Would you be able to rebase this PR on 3.11? It would be nice if we could get this documentation fix in the next patch release 3.11.1.

@patrickdupuis patrickdupuis added comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help" comp: help schelp documentation and removed comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help" labels Jul 12, 2020
@brunoruviaro
Copy link
Contributor Author

thanks! Sorry I did not have time to do the rebase. If do any similar minor PRs in the future I'll remember to use the current stable branch.

@patrickdupuis
Copy link
Contributor

No worries ;) develop is totally fine for all types of PRs.

@mossheim mossheim merged commit 14c8265 into supercollider:develop Jul 12, 2020
@mossheim
Copy link
Contributor

thanks!

@patrickdupuis patrickdupuis mentioned this pull request Jul 12, 2020
Merged
4 tasks
mossheim added a commit that referenced this pull request Jul 12, 2020
@mossheim
Merge pull request #5086 from patrickdupuis/cherry-pick5078
7e8aa46 
Cherry-pick #5078 into 3.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdupuis patrickdupuis patrickdupuis approved these changes

Assignees
No one assigned
Labels
comp: help schelp documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunoruviaro @patrickdupuis @mossheim