classlib: fix EventPatternProxy premature cleanup of faded-in stream #4996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telephon
reviewed
Jun 7, 2020
telephon
approved these changes
Jun 8, 2020
telephon
requested changes
Jun 8, 2020
telephon
approved these changes
Jun 11, 2020
mossheim
reviewed
Jun 13, 2020
There was a problem hiding this comment.
looks good, can you please rebase this branch to resolve the conflicts?
…(rebased) Rebased onto fba43fa
eleses
force-pushed
the
topic/EventPatternProxy-fadeTime-cleanup-fix
branch
from
38ddcd0 to
e57b6d0
Compare
|
I'll leave a note here that person who first reported this bug says (on the forum link in the initial report) that this fix didn't work for them. I have no idea why. It worked for me in literally all the instances of SC I've patched with this, i.e. backport to 3.10.4 and 3.11.0. But they are on a Mac, and I don't have one I can install SC on, alas. Since we get no classlib unit test output from CI, it would be helpful if someone (else) with SC on a Mac can manually check if this fix working on that OS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
#Fixes #4954
I have checked that fix this works with both the present cleanup system and the one proposed in #4806.
Types of changes
To-do list