boost_sync: workaround to build with Boost 1.72.0 #4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2020
mossheim
added
comp: 3rd party
Closed
mossheim
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
thanks! after some thought (and after @patrickdupuis pinged me on the dev call about this today) i've decided we should just merge this as-is. this is a totally temporary workaround that has already been tested and shown to work, and i believe the risk of this breaking anything is quite small (and we will put out a release candidate for 3.11.1 to test this in any case).
in develop, we will update to latest boost and boost_sync.
also, i don't know why but the travis CI result is not showing on this PR. it passed: https://travis-ci.org/github/supercollider/supercollider/builds/693339150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this off from #4986, see also #4914.