Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Document.text when using non-ascii characters #4978

Merged
merged 1 commit into from
May 27, 2020
Merged

Fix Document.text when using non-ascii characters #4978

merged 1 commit into from
May 27, 2020

Conversation

bgola
Copy link
Contributor

@bgola bgola commented May 27, 2020

Purpose and Motivation

Fixes #4977

Types of changes

  • Bug fix

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

mossheim
mossheim approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@adcxyz
Copy link
Contributor

adcxyz commented May 27, 2020

Great, should work for Document.string too!

@mossheim mossheim merged commit b95b6da into supercollider:develop May 27, 2020
@mossheim mossheim added comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library" env: SCIDE labels May 27, 2020
@patrickdupuis patrickdupuis mentioned this pull request Jul 6, 2020
Merged
4 tasks
mossheim added a commit that referenced this pull request Jul 7, 2020
@mossheim
Merge pull request #5063 from patrickdupuis/cherry-pick4978
0987ff6 
Cherry-pick #4978 into 3.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossheim mossheim mossheim approved these changes

Assignees
No one assigned
Labels
comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library" env: SCIDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class 'Document' (SCIDE) unicode problems
3 participants
@bgola @adcxyz @mossheim