Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertFloatEquals string formatting #4946

Merged
merged 1 commit into from
May 21, 2020
Merged

Fix assertFloatEquals string formatting #4946

merged 1 commit into from
May 21, 2020

Conversation

patrickdupuis
Copy link
Contributor

Purpose and Motivation

Fixes the message that's posted when using assertFloatEquals. Currently, the formatting is done only on the last bit of the String:

PASS: a TestFoo: test_foo1 - foo this is true
Is:
	 % 
Should equal (within range 0.0001):
	 1.0

Types of changes

  • Bug fix

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

@patrickdupuis patrickdupuis added bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs. comp: UnitTest labels May 20, 2020
mossheim
mossheim approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mossheim
Copy link
Contributor

can you rebase this on 3.11 please?

@patrickdupuis patrickdupuis force-pushed the topic/fix-string-format branch from d2dc1d4 to f43e2cb Compare May 20, 2020 16:20
@patrickdupuis
Copy link
Contributor Author

done!

@dyfer
Copy link
Member

dyfer commented May 21, 2020

@brianlheim @patrickdupuis should the base branch be changed to 3.11 and then it's good to go?

@mossheim mossheim changed the base branch from develop to 3.11 May 21, 2020 01:58
@mossheim
Copy link
Contributor

yep, i just changed it @dyfer

@dyfer dyfer merged commit a1aa650 into supercollider:3.11 May 21, 2020
@patrickdupuis patrickdupuis deleted the topic/fix-string-format branch May 21, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossheim mossheim mossheim approved these changes

Assignees
No one assigned
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickdupuis @mossheim @dyfer