Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TestBuffer #4938

Merged
merged 1 commit into from
May 17, 2020
Merged

Refactor TestBuffer #4938

merged 1 commit into from
May 17, 2020

Conversation

patrickdupuis
Copy link
Contributor

Purpose and Motivation

This PR splits TestBuffer into two UnitTests: TestBuffer.sc and TestBuffer_server.sc

Types of changes

  • UnitTests

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

mossheim
mossheim suggested changes May 17, 2020
View reviewed changes
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! can you please use an uppercase S for TestBuffer_Server? everything else looks good

@patrickdupuis
Copy link
Contributor Author

Thanks for the quick review! Renamed as requested.

@mossheim mossheim added comp: testing UnitTest class, refactors of existing tests, etc.; don't use if just adding tests as part of a PR and removed comp: UnitTest labels May 17, 2020
@mossheim
Copy link
Contributor

thanks! fyi @patrickdupuis "comp: UnitTest" is for changes to the actual unit testing framework, for testsuite changes it's "comp: testsuite".

@mossheim mossheim merged commit 90ed4a1 into supercollider:develop May 17, 2020
This was referenced May 17, 2020
Merged
Closed
@patrickdupuis patrickdupuis mentioned this pull request Jun 1, 2020
Merged
4 tasks
mossheim added a commit that referenced this pull request Jun 1, 2020
@mossheim
Merge pull request #4989 from patrickdupuis/cherry-pick_4938
19d6015 
Cherry-pick #4938 into 3.11
@patrickdupuis patrickdupuis deleted the topic/test_buffer branch July 6, 2020 01:05
@mossheim mossheim added comp: testing comp: testing UnitTest class, refactors of existing tests, etc.; don't use if just adding tests as part of a PR and removed comp: testing UnitTest class, refactors of existing tests, etc.; don't use if just adding tests as part of a PR labels Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossheim mossheim mossheim approved these changes

Assignees
No one assigned
Labels
comp: testing UnitTest class, refactors of existing tests, etc.; don't use if just adding tests as part of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickdupuis @mossheim