Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supernova: ignore non-scsyndef files #4917

Merged
merged 1 commit into from
May 9, 2020
Merged

supernova: ignore non-scsyndef files #4917

merged 1 commit into from
May 9, 2020

Conversation

dyfer
Copy link
Member

@dyfer dyfer commented May 8, 2020 •
edited
Loading

Purpose and Motivation

Fixes #4916

It seems to work on my system but I'd appreciate if others take a look whether this is a correct fix.

Types of changes

  • Bug fix

To-do list

  • Code is tested
  • All tests are passing
    • there are no tests for this...
  • This PR is ready for review

@dyfer dyfer linked an issue May 8, 2020 that may be closed by this pull request
Supernova /d_loadDir does not ignore non-scsyndef files #4916
Closed
mossheim
mossheim approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

i see no issue with putting this in the 3.11.x releases, the error and solution are both straightforward. thanks @jamshark70 also for reporting this!

@dyfer
Copy link
Member Author

dyfer commented May 8, 2020 •
edited
Loading

thanks @brianlheim
an afterthought: would it make sense to put ".scsyndef" in a constant in SC_Filesystem.hpp and reference that from both scsynth and supernova?

@mossheim mossheim merged commit 4dc02e4 into supercollider:3.11 May 9, 2020
@dyfer dyfer mentioned this pull request May 9, 2020
Closed
@mossheim
Copy link
Contributor

mossheim commented May 9, 2020

an afterthought: would it make sense to put ".scsyndef" in a constant in SC_Filesystem.hpp and reference that from both scsynth and supernova?

we discussed this in slack (i forgot to respond to it here) -- i wouldn't mind if this PR did that, after all we do have a lot of constants for things like it, but it isn't too necessary IMO. it's worth noting though that the server implementations could definitely stand to be combined a bit, especially on simple functionality like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossheim mossheim mossheim approved these changes

Assignees
No one assigned
Labels
comp: supernova
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supernova /d_loadDir does not ignore non-scsyndef files
2 participants
@dyfer @mossheim