Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update scel submodule #4855

Merged
merged 1 commit into from
Apr 23, 2020
Merged

update scel submodule #4855

merged 1 commit into from
Apr 23, 2020

Conversation

mossheim
Copy link
Contributor

@mossheim mossheim commented Apr 6, 2020

Purpose and Motivation

this brings in a fix that prevented some users from building on Ubuntu, as well as other features, check git log in scel
for more details.

Types of changes

  • Bug fix
  • New feature

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

@stevemcc stevemcc mentioned this pull request Apr 10, 2020
Closed
@mossheim mossheim mentioned this pull request Apr 13, 2020
Closed
dyfer
dyfer approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@dyfer dyfer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed this on macOS and sclang-mode still works so I guess it's good :)

@dyfer dyfer merged commit 304ff81 into supercollider:3.11 Apr 23, 2020
@dyfer
Copy link
Member

dyfer commented Apr 23, 2020

thank you @brianlheim

@mossheim mossheim deleted the topic/update-scel branch April 23, 2020 00:59
@bjornmossa
Copy link

I saw some changes related to company-mode.
Does that mean company-mode autocomplete will work automaticaly with this changes (if installed)?

@mossheim
Copy link
Contributor Author

mossheim commented Jul 8, 2020

@bjornmossa i am not the scel maintainer, but it appears so. this is the PR: supercollider/scel#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyfer dyfer dyfer approved these changes

Assignees
No one assigned
Labels
organizational
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mossheim @dyfer @bjornmossa