Appveyor: workaround for storage limit #4847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossheim
changed the title
|
in case it's not clear, i intend this as a TEMPORARY workaround for the artifact storage limit. it will let us continue to merge PRs and get S3 storage, but deployment for releases is now turned off. this should be reverted as soon as possible once Appveyor raises our storage limit. i have already submitted a request to them on their support forum. |
it seems like it might take appveyor some time to address this, so in the meantime i am going to try to manually push to S3 (and disable github release deployment altogether) using --dry-run right now so even success will not actually upload any artefacts
|
i think this is ready to merge now. the travis-ci failures are due to a transitory issue on travis's end and are not related to this PR's changes in any way, so they can be safely ignored. |
mossheim
added
comp: appveyor
and removed
Work In Progress (WIP) - don't merge yet
labels
mossheim
changed the title
joshpar
approved these changes
Apr 3, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems like it might take appveyor some time to address us hitting our storage limit due to the COVID pandemic, so in the meantime i propose we use this method to manually push to S3. by not listing the ZIP and html file we push to S3 as an "appveyor artifact", we avoid having them also store it, which would count toward our Appveyor storage limit.
that storage behavior and retention policy is currently an unconfigurable aspect of appveyor. i've asked their support about this in the past and been told manually deploying like in this PR is the only way to avoid it.
this is a temporary workaround. we will need to revert this (or augment it) before a release, since it does not handle github deployments. it may be useful again in the future if we ever hit this limit again at an inopportune moment.