Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: hide boost warnings #4804

Merged
merged 1 commit into from
Mar 9, 2020
Merged

build: hide boost warnings #4804

merged 1 commit into from
Mar 9, 2020

Conversation

dyfer
Copy link
Member

@dyfer dyfer commented Mar 8, 2020

Purpose and Motivation

When building SC, warnings "your boost version is older than your compiler" are displayed frequently. These changes should remedy that, per advice by @brianlheim

Types of changes

  • (Bug fix)

To-do list

  • Code is tested
  • This PR is ready for review

@dyfer dyfer added the comp: build CMake build system label Mar 8, 2020
@mossheim
Copy link
Contributor

mossheim commented Mar 8, 2020

sorry, i messed up. -isystem (or whatever MSVC's equivalent is) doesn't silence warnings from the #warning pragma, which is what this is. let's revert this and add a define for the suppression macro at the top level CMakeLists. i think we can just use it unconditionally, as i suspect even without this message we'll be able to determine if an untested/unsupported compiler is the cause of someone's problem when they come looking for help.

@dyfer dyfer force-pushed the topic/hide-boost-warnings branch from dd9c472 to 28247da Compare March 8, 2020 01:30
@dyfer dyfer force-pushed the topic/hide-boost-warnings branch from 28247da to 7d5d0a8 Compare March 8, 2020 01:33
nhthn
nhthn approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@nhthn nhthn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah, this fixes a major annoyance for building on windows

@mossheim mossheim merged commit 22e45f7 into supercollider:develop Mar 9, 2020
@mossheim mossheim mentioned this pull request Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossheim mossheim mossheim approved these changes

@nhthn nhthn nhthn approved these changes

Assignees
No one assigned
Labels
comp: build CMake build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dyfer @mossheim @nhthn