Added/Corrected phase documentation #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added another minor comment on |
telephon
reviewed
Mar 3, 2020
| @@ -14,7 +14,7 @@ classmethods:: | |||
| method::ar, kr | |||
|
|
|||
| argument::freq | |||
| Frequency in Hertz. | |||
| Frequency in Hertz. For efficiency reasons, only positive values yield in correct behavior. | |||
|
|
|||
There was a problem hiding this comment.
I don't think that "yield in sth." is correct. Better is "result in sth." here (or otherwise "yield sth.").
telephon
approved these changes
Mar 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
fixing wrong/missing information on
iphaseoffset range forLFParandLFCub.Types of changes
To-do list