Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCDoc: use vector for recursive function #4713

Merged
merged 1 commit into from
Feb 15, 2020
Merged

SCDoc: use vector for recursive function #4713

merged 1 commit into from
Feb 15, 2020

Conversation

mossheim
Copy link
Contributor

Purpose and Motivation

otherwise may end up segfaulting on deep trees

this function is only used in SCDoc/main.cpp, which is just a test driver for the SCDoc parser. that file is not even compiled normally when building. so this has no impact on anything user facing.

Types of changes

  • Bug fix

To-do list

  • Code is tested - old code segfaults on a deeply nested tree, this code doesn't
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

otherwise may end up segfaulting on deep trees
@mossheim mossheim added the comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help" label Dec 29, 2019
@jrsurge jrsurge self-assigned this Jan 4, 2020
@jrsurge jrsurge self-requested a review January 4, 2020 12:45
@jrsurge jrsurge removed their assignment Jan 4, 2020
@mossheim mossheim merged commit bc32f32 into supercollider:develop Feb 15, 2020
@mossheim mossheim deleted the topic/scdoc-dump-node branch February 15, 2020 21:57
@mossheim mossheim restored the topic/scdoc-dump-node branch April 10, 2020 18:48
@mossheim mossheim deleted the topic/scdoc-dump-node branch August 1, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants