plugin intf: fix compile error, change type of arg to bool #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvc complains about signed to unsigned conversion
|
note -- the compile error referred to in the title is in the cookiecutter plugin, which uses a higher and more stringent set of compiler warnings/errors than this project |
|
@brianlheim you're two steps ahead! 🥇 |
|
I think this is fine, I tested it with example-plugins. I think we should make sure this gets into 3.11 to avoid making a breaking change later, right? |
dyfer
approved these changes
Feb 18, 2020
|
thanks @dyfer ! i don't think it's vital for 3.11 but i didn't consider the breaking change part, it should probably be cherry picked now that we have a 3.11 branch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
this is an addendum to #4356
msvc complains about signed to unsigned conversion ( see
supercollider/cookiecutter-supercollider-plugin#21)
i also changed this argument to a boolean since there are really only
two possible values. it made sense to use
intin the C interface sincebool is not a fundamental C type
Types of changes
last week and no releases have occurred from it in the meantime)
To-do list