Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 11 support #4611

Merged
merged 3 commits into from
Nov 2, 2019
Merged

Xcode 11 support #4611

merged 3 commits into from
Nov 2, 2019

Conversation

mossheim
Copy link
Contributor

@mossheim mossheim commented Oct 6, 2019

Purpose and Motivation

See commit messages for details

Types of changes

  • Bug fix
  • Breaking change -- boost >= 1.66 is now strictly required by the build system. Technically, this is not true as you don't absolutely need to build sclang to use the project. However, Boost is easy to obtain and this saves headaches later in the common case.

To-do list

  • Code is tested -- I can now build Boost locally
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

@mossheim
supernova: workaround for appleclang 11
d1a0217 
1. Boost used in supernova doesn't compile with Xcode 11
- because of issue in boost::asio
- fix was to add  before boost::asio includes iff the compiler is appleclang > 11
- other uses of boost asio in sclang and scsynth don't have this problem, probably because they don't instantiate certain things or include certain headers
@mossheim
CMake: require boost >= 1.66
3280ac8 
This is necessary after including boost.math stuff in sclang

See PR #3672
@mossheim mossheim added comp: supernova comp: build CMake build system labels Oct 6, 2019
@mossheim
Remove code for pre-1.51 boost
2004f97 
No longer supported by project
@mossheim mossheim mentioned this pull request Oct 7, 2019
Merged
4 tasks
@joshpar joshpar self-requested a review November 2, 2019 22:05
@joshpar joshpar merged commit 92de26c into supercollider:3.10 Nov 2, 2019
@mossheim mossheim deleted the boost-xcode branch November 3, 2019 16:24
@nhthn
Copy link
Contributor

nhthn commented Nov 17, 2019

Breaking change -- boost >= 1.66 is now strictly required by the build system.

this is a breaking change merged into a patch release -- is this justifiable?

i guess that's the point of supercollider/rfcs#1 either way!

@mossheim
Copy link
Contributor Author

yes, it is justifiable by the reasons in the PR text. it's a bump in requirements for those building sc, not for those using it.

@nhthn
Copy link
Contributor

nhthn commented Nov 17, 2019

cool thanks for the explanation 👌

@mossheim mossheim restored the boost-xcode branch April 10, 2020 18:53
@mossheim mossheim deleted the boost-xcode branch August 1, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpar joshpar joshpar approved these changes

Assignees
No one assigned
Labels
comp: build CMake build system comp: supernova
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mossheim @nhthn @joshpar