Work around build errors on musl libc #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently musl does not support GLOB_TILDE but it is on their roadmap [1]. This patch is no fix and changes functionality for musl. A slightly changed functionality seems better than being unable to build. For glibc and future versions of musl this change is a noop. [1] https://wiki.musl-libc.org/roadmap.html
|
Sorry about the force push. Messed up the commit message but shouldn't impact anyone. |
mossheim
suggested changes
Aug 14, 2019
4 tasks
jpburstrom
pushed a commit
to jpburstrom/supercollider
that referenced
this pull request
Aug 21, 2019
* Work around build errors on musl libc Currently musl does not support GLOB_TILDE but it is on their roadmap [1]. This patch is no fix and changes functionality for musl. A slightly changed functionality seems better than being unable to build. For glibc and future versions of musl this change is a noop. [1] https://wiki.musl-libc.org/roadmap.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
This continues on from and replaces #4391.
Tests 10 (server_test_run) and 16 (perf_counter_test_run) from
make testfail on my machine but they also fail without these changes.Types of changes
To-do list