add Platform:*hasQtWebEngine, don't mislead about help browser #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossheim
added
comp: Qt GUI
nhthn
reviewed
Aug 7, 2019
nhthn
approved these changes
Aug 9, 2019
lnihlen
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
if built without QtWebEngine, the IDE should not print "for help press
Ctrl-D/Cmd-D" since this shortcut won't do anything. Changing this
message from Main.sc requires programatically knowing whether this
feature is available.
Types of changes
Checklist
Remaining Work
Maybe we could post a message that leads to doc.sccode.org? Or give
instructions (or a link to instructions) for rendering documentation yourself?