Topic/nodeproxy bundling queue #4461
Conversation
|
There is a related problem that requires a fix: #4457 |
|
@redFrik can you take a look if it solves the issues you've had? Thanks! |
|
@telephon just a reminder to label your PRs when you submit them :) |
telephon
added
comp: class library
|
@telephon if you mean this https://www.listarc.bham.ac.uk/lists/sc-users/msg64271.html //recompile
s.boot;
//run this multiple times. stop with cmdperiod. sounds only first time
(
Ndef(\out, {Ndef.ar(\saw)}).play;
Ndef(\saw, {VarSaw.ar([400, 400.4], 0, 0.2, 0.1.poll)});
)
//this one will sound each time
(
fork{
Ndef(\out, {Ndef.ar(\saw)}).play;
0.1.wait;
Ndef(\saw, {VarSaw.ar([400, 400.4], 0, 0.2, 0.1.poll)});
}
) |
|
this branch has conflicts FYI @telephon |
test: make sure that a status message has been sent
This makes sure that: a) SynthDefs have a unique name instead of a channel id b) SynthDefs are freed even when the bundle is canceled Not setting the nodeID to nil is ok, nothing substantial depends on it. For some reason, `addPrepare` needs to be replaced by a direct adding. I would have thought that either way should be OK, but `addPrepare` will cause SynthDef not found errors under load (when bundles are canceled). This may need further checking, including the server behaviour.
telephon
force-pushed
the
topic/nodeproxy-bundling-queue
branch
from
641b2dc to
490ccac
Compare
Thanks @redFrik I'll see what I can do about that silly problem. |
|
What's the status of this @telephon? Are we awaiting further changes or will that be another PR? |
|
@muellmusik that should be another one. It might be related, but I'm not sure. |
|
Okay, then any reason not to merge this? @brianlheim or @jamshark70 should we hold off for reviews from either of you? |
|
I think it looks ok -- after updating the unit test, did you try the unit test without the code fix? It should fail w/o code fix and pass with it. |
|
It's long ago, but I usually do something like that. |
| var numBefore, numAfter; | ||
| server.sendStatusMsg; | ||
| server.sync; | ||
| numBefore = server.statusWatcher.numSynthDefs; |
There was a problem hiding this comment.
since these few lines of code consumed quite a bit of time in discussion, could you please add a brief comment indicating why server.sendStatusMsg is here so the next person to read it understands it more readily?
Purpose and Motivation
This fixes #3344.
It makes sure that:
a) SynthDefs have a unique name instead of a channel id
b) SynthDefs are freed even when the bundle is canceled
Not setting the nodeID to nil is ok, nothing substantial depends on it.
For some reason,
addPrepareneeds to be replaced by a direct adding.I would have thought that either way should be OK, but
addPreparewill cause SynthDef not found errors under load (when bundles are
canceled). This may need further checking, including the server
behaviour.
Types of changes
To-do list