Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: fix for #4412 - extra SuperCollider directory in Platform.recordingsDir #4420

Merged

Conversation

jrsurge
Copy link
Member

@jrsurge jrsurge commented May 26, 2019

Purpose and Motivation

fixes issue #4412.

Changes Platform.recordingsDir on Windows to return:

C:\Users\<username>\Documents\SuperCollider\Recordings

Before this commit - C:\Users\<username>\Documents\SuperCollider\SuperCollider\Recordings

Types of changes

  • Bug fix

To-do list

  • Code is tested
  • This PR is ready for review

@jrsurge jrsurge force-pushed the topic/fix-windows-recordingsdir branch from 0a5662e to 388052b Compare June 2, 2019 07:58
@nhthn nhthn added the comp: class library SC class library label Jun 2, 2019
@jrsurge jrsurge force-pushed the topic/fix-windows-recordingsdir branch from 388052b to 5fad117 Compare June 2, 2019 19:53
@jrsurge jrsurge changed the base branch from develop to 3.10 June 2, 2019 20:08
@nhthn nhthn added this to the 3.10.3 milestone Jun 2, 2019
Copy link
Contributor

@nhthn nhthn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: class library SC class library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants