-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classlib: Event: Fix strum, issue #4405 #4406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very plausible!
for the sake of completeness, other way to implement it could be to extract the ids from bndl like Line 587 (without this patch), could be: [15 /* \n_set */, bndl.flop[2], \gate, 0].flop,
This patch follows implementation semantics used before in that function and |
And, I just saw a possible source of confusion: Before, line 554:
should The thing is that I'm just sharing my reasoning about this. |
reversing an array of a couple of numbers will certainly be faster than a flop of the whole structure. If in doubt, you can check, e.g.: a = (0..32);
b = [2, a, 5];
bench { a.reverse };
bench { b.flop };
No, as you say, the order of the variable
I'll answer anyway. It in supercollider/SCClassLibrary/Common/Collections/Event.sc Lines 535 to 538 in a805ec9
|
Thanks for the review Julian. My first thought about the variable was it was not initialised, "that's wrong", then I thought it's there because clearly marks the place for the ids defined later as a name instead of raw nil. However, after that I decided for me it would have been better to use nil because the next operations in that array slot makes clear that there go ids. I was a little jocular. |
ah, yes! Thanks for the discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
Should this be merged into |
Purpose and Motivation
This patch Fixes #4405 issue with strum parameter for Event as described there.
Types of changes
To-do list