Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class library: Deprecate String.scDir #4374

Merged
merged 2 commits into from
Jun 4, 2019
Merged

class library: Deprecate String.scDir #4374

merged 2 commits into from
Jun 4, 2019

Conversation

nhthn
Copy link
Contributor

@nhthn nhthn commented Apr 4, 2019

Purpose and Motivation

String.scDir is an old alias for Platform.resourceDir. this PR fixes all erroneous uses of it in the SC code base and causes the method to emit a deprecation warning.

Types of changes

  • Documentation
  • Breaking change

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

@nhthn nhthn added this to the 3.11 milestone Apr 4, 2019
telephon
telephon reviewed Apr 6, 2019
View reviewed changes
Copy link
Member

@telephon telephon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good when reading. I haven't tested it.

It would be good to have some tests for the directory methods actually. But not necessarily here.

@nhthn nhthn force-pushed the topic/string-scdir branch from 63e39be to d7cce86 Compare June 2, 2019 09:01
mossheim
mossheim previously requested changes Jun 2, 2019
View reviewed changes
SCClassLibrary/deprecated/3.11/deprecated-3.11.sc Outdated Show resolved Hide resolved
@mossheim mossheim mentioned this pull request Jun 2, 2019
Open
@nhthn nhthn force-pushed the topic/string-scdir branch from d7cce86 to e406e98 Compare June 2, 2019 22:28
@nhthn nhthn dismissed mossheim’s stale review June 3, 2019 01:22

EOF newline added

mossheim
mossheim approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mossheim mossheim merged commit 8cbabe1 into supercollider:develop Jun 4, 2019
@joshpar joshpar mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telephon telephon telephon left review comments

@mossheim mossheim mossheim approved these changes

Assignees
No one assigned
Labels
API change comp: class library SC class library
Projects
None yet
Milestone
3.11
Development

Successfully merging this pull request may close these issues.
3 participants
@nhthn @telephon @mossheim