-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake plugin template (used by cookiecutter): add NOVA_SIMD build option and include boost. #4354
CMake plugin template (used by cookiecutter): add NOVA_SIMD build option and include boost. #4354
Conversation
Just wanted to ping this PR to see if there were any thoughts on these changes, alternative approaches, etc. I'd be happy to follow up with those suggestions. Otherwise, it'd be great to see a milestone tag pop up on this one ;) |
hi mike! right now we can't merge anything to 3.10 or develop branches because there is a big code reformat under way. |
Thanks, Nathan. No problem, just wanted to see if there had been any eyeballs on this, through comments or a milestone assignment, so I could address any suggestions for changes. Thanks for checking in! |
@mtmccrea Thanks for the PR! I'm just looking at this now. I am OK with the nova-simd option but IMO people should include Boost as a dependency themselves if they need it, and they should also IMO use packaged boost rather than relying on the one in SC, which is first of all not a full copy of boost, second of all tailored for SC's purposes, and third of all updated on its own schedule. Is there something specific you need it for? I can add a note in the README for the cookiecutter repo on how to include boost if that would satisfy you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per comment above
@brianlheim sorry to have let this sit for so long. I think it's reasonable to have people include boost only if they need it. I've removed that include. And sure I think it would be helpful to add a note in the docs about including external libraries. Thanks! |
@mtmccrea no need to apologize. thanks for updating! |
Purpose and Motivation
The cookiecutter plugin build workflow doesn't currently support nova-simd or include the boost library.
Types of changes
This adds the
NOVA_SIMD
build optionand includes theby default so it's available to the cookiecutter plugin build workflow.boost
libraryNote: The default
DNOVA_SIMD
flag isON
.This gets the job done for making these libraries available to plugins, but I'm open to other options for optionally including these.