-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy mixer edit gui should use proxyspace #4339
Proxy mixer edit gui should use proxyspace #4339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of places to simplify -- otherwise, if it's basically an indentation change to wrap inside the use
function, then it's fine 👍
|
||
.action_({ arg btn, mod; | ||
this.proxyspace.use { | ||
protect { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protect
inside use
is not needed, because use
already does protect
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah thank, did not look up the implementation of .use
this.name_(newState[\name]) | ||
}; | ||
this.proxyspace.use { | ||
protect { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same (don't need protect
here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, both done!
LGTM now.
Also, for future reference, Approving. |
retriggering AppVeyor build |
Purpose and Motivation
Bug fix, Fixes #4335.
A ProxyMixer has a proxyspace that it shows, so all named it displays are within that proxyspace.
The editGui in the mixer did not use the proxyspace, but relied on either using Ndefs, or the
mixer's proxyspace being the currentEnvironment.
Thus, when the mixer's proxyspace is not current, proxy names would be displayed as anonymous.
This PR ensures that the editGui shows all names as found within the mixer's proxyspace.
Tests for correct functioning: